Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API key error if IGN selected as address provider even if key is provided #513

Closed
1 task done
nicogodet opened this issue Aug 17, 2023 · 4 comments
Closed
1 task done

Comments

@nicogodet
Copy link
Contributor

What is the bug?

image

It pops every time I open plugin even if API key is provided in base map tab.
image

Versions

Versions :

  • Lizmap Web Client : 3.6.5
  • Lizmap plugin : 3.16.3
  • QGIS Desktop : 3.28.9
  • QGIS Server : 3.28.9
  • Py-QGIS-Server : 1.8.8
  • QGIS Server plugin atlasprint : 3.3.2
  • QGIS Server plugin lizmap_server : 2.8.0
  • QGIS Server plugin wfsOutputExtension : 1.8.0

Check Lizmap plugin

  • I have done the step just before in the Lizmap QGIS desktop plugin before opening this ticket. Otherwise, my ticket is not considered valid and might get closed.
@nicogodet
Copy link
Contributor Author

nicogodet commented Aug 17, 2023

Open Lizmap
image
Press OK
image

Check triggered too soon ?

Should be fixed by cbd52eb. Ref. #477

@nicogodet
Copy link
Contributor Author

lizmap-plugin/lizmap/plugin.py

Lines 3755 to 3757 in 99c648e

# Get config file data
self.read_cfg_file()

        # Get config file data
+       self.dlg.block_signals_address(True)
        self.read_cfg_file()
+       self.dlg.block_signals_address(False)

Might be dirty

@Gustry Gustry closed this as completed in a925257 Aug 21, 2023
@Gustry
Copy link
Member

Gustry commented Aug 21, 2023

Not dirty, it looks correct ;-)
You can see indeed the previous commit was like very similar :D

@nicogodet
Copy link
Contributor Author

I made these changes locally, I just would like to test a bit before you push next release ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants