Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dist folder thing #574

Open
kfarr opened this issue Jun 10, 2024 · 3 comments
Open

fix dist folder thing #574

kfarr opened this issue Jun 10, 2024 · 3 comments
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Jun 10, 2024

From @vincentfretin:

For dist folder, meaning copying files from public folder to dist and deploying dist to firebase and as well make index.html a resource handled by webpack so the url to dist files are versioned will allow to lazy load react components and libraries. Some work was done in 3DStreet/3dstreet-editor#358 but was probably blocked by the webpack config at the time.

@kfarr kfarr converted this from a draft issue Jun 10, 2024
@kfarr kfarr assigned kfarr and vincentfretin and unassigned kfarr Jun 10, 2024
@kfarr kfarr moved this from To Do - High Prio to To Do - Soon in 3DStreet Dev Tracking Jun 11, 2024
@vincentfretin
Copy link
Collaborator

new PR is #557

@kfarr kfarr moved this from To Do - Soon to To Do - High Prio in 3DStreet Dev Tracking Jun 14, 2024
@kfarr
Copy link
Collaborator Author

kfarr commented Aug 30, 2024

note -- just ran into a related issue again while testing on https://dev-3dstreet.web.app

  • the old build was cached in my browser, had to use network tools to break the cache and see the updated version

instead the improved dist method will have cachebusting for each deploy?

@kfarr kfarr moved this from To Do - Soon to To Do - High Prio in 3DStreet Dev Tracking Aug 30, 2024
@vincentfretin
Copy link
Collaborator

That's right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do - High Prio
Development

No branches or pull requests

2 participants