Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scene title is not saved in the JSON file #553

Closed
Algorush opened this issue Jun 4, 2024 · 2 comments
Closed

New scene title is not saved in the JSON file #553

Algorush opened this issue Jun 4, 2024 · 2 comments
Assignees

Comments

@Algorush
Copy link
Collaborator

Algorush commented Jun 4, 2024

There's always title='scene'

@Algorush Algorush self-assigned this Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in 3DStreet Dev Tracking Jun 5, 2024
@vincentfretin vincentfretin moved this from Backlog (Not Ready) to To Do - High Prio in 3DStreet Dev Tracking Jun 5, 2024
@kfarr
Copy link
Collaborator

kfarr commented Jun 6, 2024

@Algorush thanks I tested and reproduced, however this is just for downloaded 3dstreet.json files and not cloud, the cloud title and rename saving seems to work as expected.

Here seems to be the offending line:
https://github.com/3DStreet/3dstreet/blob/main/src/json-utils_1.1.js#L58

@kfarr kfarr moved this from To Do - High Prio to To Do - Soon in 3DStreet Dev Tracking Jun 6, 2024
@Algorush Algorush moved this from To Do - Soon to For Review in 3DStreet Dev Tracking Jun 8, 2024
@kfarr
Copy link
Collaborator

kfarr commented Jun 10, 2024

fixed with #573

@kfarr kfarr closed this as completed Jun 10, 2024
@github-project-automation github-project-automation bot moved this from For Review to Done in 3DStreet Dev Tracking Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants