Feat/finish new designs migration #389
Conversation
- Move MultiSelect.ts -> Autocomplete.ts and allow fetching new data from a source url
chore: merge develop into main
* Fix timezone issue once and for all * improved timezone testing * Update ci.yml set locale so that dates are formatted correctly when running tests * Update ci.yml trying another way * Update ci.yml trying for timelog tests * Try global env --------- Co-authored-by: Matt Bell <[email protected]>
* Logging of testrun context, with explicit locale setting * Stepwise check for yml typos * Fix yml indent --------- Co-authored-by: Derek Crannaford <[email protected]>
* Change to mount instead of install * Improve source code details section * Less output from GIT log
feat: display task type form fields
Moved it into templates/base/ - No longer runs the tag controller for each instance of tag partial included in page - Can now reload tags when the tag modal is closed
I broke it in f1fb50d
…pisoftware/cmfive-core into feat/FinishNewDesignsMigration
…pisoftware/cmfive-core into feat/FinishNewDesignsMigration
|
|
||
| namespace Html\Form; | ||
|
|
||
| use LogService; |
There was a problem hiding this comment.
This shouldn't be here
| $buffer .= "<script>$(function(){try{\$('textarea.ckeditor').each(function(){CKEDITOR.replace(this)})}catch(err){}});</script>"; | ||
| // $buffer .= "<script>$(function(){try{\$('textarea.ckeditor').each(function(){CKEDITOR.replace(this)})}catch(err){}});</script>"; | ||
|
|
||
| $buffer .= "<script>document.addEventListener('DOMContentLoaded', () => { [...document.querySelectorAll('textarea.ckeditor')].forEach(x => { CKEDITOR.replace(x) }) })</script>"; |
There was a problem hiding this comment.
querySelectorAll should already return an array, so no need (I think) to unpack array into another array
There was a problem hiding this comment.
It returns an Array-like NodeList structure which you cannot directly iterate over with .forEach
| } | ||
|
|
||
| /** level 2 */ | ||
| .cmfive-comment > |
There was a problem hiding this comment.
The thing that this doesn't have that JS did is that the comment nesting length is really only limited by the browsers ability to render it (i.e. we can nest a lot of comments). We can have a billion nested comment replies and this would stop rendering colours after the 6th nested reply.
One way around this is to pass a number to the partial that represents its current level and when it recurses increase that number by 1. Then use that number % 5 to print a css class of "level-N" and style those classes
| } | ||
| } | ||
| ?> |
There was a problem hiding this comment.
Best practices suggest not having a closing php tag at the end of a file
| createApp({ | ||
| components: { | ||
| EditFieldComponent, | ||
| testComponent |
There was a problem hiding this comment.
We can remove the testComponent
| @@ -0,0 +1 @@ | |||
| <?php echo $form; ?> | |||
There was a problem hiding this comment.
Another closing php tag
Fix: Vite Dirname parsing codepipline aware
Checklist
Description
Various changes to Tag and Form modules, changes to Bootstrap5 code, Vue2 to Vue3 (yet to be complete for Form module, may be required in Admin module, for example in the users list? perhaps?) conversion, etc.
Changelog
refs:
issues:
Other Information
Docs pull request: