Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopBar exceptions when newDesign and oldDesign templated modules are deployed concurrently. #345

Open
DerekCrannaford opened this issue Sep 4, 2024 · 0 comments

Comments

@DerekCrannaford
Copy link
Contributor

If:

  • a module exists with TopMenu 'true' config
  • and the service class has no ->navigation() method

Then:

  • any page site-wide with newDesigns freezes as a blank black screen

Related, on any newDesigns page sitewide:

  • if: an (oldDesigns) module expected TopMenu to land on index action by default
  • then: this is no longer possible, and the (default) module index action is unreachable

careck : "both of these look like a bug to me"

These relate to newDesigns deprecating the 'hover to pop dropdown' from topBar of oldDesigns.
A 'click' is required to drop the items list, so no default-on-click navigation is sensible.

Possible fix?

  • newDesigns detects:
  • missing navigation method in ServiceClass - OR - navigation method exists, but returns no menu list items
    ---> automatically adds a single menu list entry, eg:"Open", as navigation to module short URL default (hence to it's index.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant