Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload proposal description to IPFS #18

Open
sembrestels opened this issue Sep 17, 2019 · 2 comments
Open

Upload proposal description to IPFS #18

sembrestels opened this issue Sep 17, 2019 · 2 comments

Comments

@sembrestels
Copy link
Member

When a proposal is created, it's description should be uploaded to IPFS and it's hash used to call the addProposal(string _title, bytes _ipfsHash, uint256 _requestedAmount, address _beneficiary) function. It probably should be a JSON with a description and a link.

The description and the link should be retreived on the frontend when needed.

You can check out the P2P Models wiki app to see an example on how this can be achieved.

@sembrestels sembrestels added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 17, 2019
@lkngtn
Copy link
Member

lkngtn commented Sep 17, 2019

How do we ensure this content gets pinned? This was a significant pain point when we were working on https://github.com/1hive/airdrop-app at Ethdenver

It looks like with the wiki app the user has to be running ipfs locally, it would be nice if this was not the case as I don't think this is common for most users (even though it would be nice if that were the case 😅).

There seems to also be some work towards smart contract being discussed here that might be relevant: https://forum.aragon.org/t/aragon-network-ipfs-pinning/824

@sembrestels sembrestels added discussion and removed good first issue Good for newcomers help wanted Extra attention is needed labels Feb 22, 2020
@sembrestels
Copy link
Member Author

We are working in parallel with the Agora Suite's Wiki and Proposals app. I think it will be interesting to connect Conviction Voting with Agora Suite's Proposals app in order to upload and discuss proposal descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants