Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clearer parameters #130

Open
sembrestels opened this issue Nov 9, 2020 · 1 comment
Open

Use clearer parameters #130

sembrestels opened this issue Nov 9, 2020 · 1 comment
Assignees
@sembrestels

Comments

@sembrestels
Copy link
Member

sembrestels commented Nov 9, 2020 •
edited
Loading

Use halfLife, maxThreshold and minThreshold instead of alpha, beta, and weight. Change the name of _minThresholdStakePercentage for minEffectiveSupplyPct.

Also, use PPM = 1e6 instead of D = 1e7 and ONE_HUNDRED_PERCENT = 1e18 to make it standard with Marketplace.
@sembrestels sembrestels self-assigned this Nov 9, 2020
@willjgriff
Copy link
Member

I think minThresholdStakePercentage should be called minActiveStakePercentage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sembrestels sembrestels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sembrestels @willjgriff