Skip to content
This repository has been archived by the owner on Jun 27, 2018. It is now read-only.

tool_consumer_instance_guid is required when it should be optional #19

Open
xow opened this issue Jan 23, 2017 · 1 comment
Open

tool_consumer_instance_guid is required when it should be optional #19

xow opened this issue Jan 23, 2017 · 1 comment

Comments

@xow
Copy link
Contributor

xow commented Jan 23, 2017

In the specification, tool_consumer_instance_guid is only listed as recommended. https://www.imsglobal.org/specs/ltiv2p0/implementation-guide#toc-42 However in the provider library it is required. https://github.com/IMSGlobal/LTI-Tool-Provider-Library-PHP/blob/master/src/ToolProvider/ToolProvider.php#L812

This means (for example) SAKAI does not work with tools using this library.

@mdjnelson
Copy link
Member

mdjnelson commented Jun 25, 2018

Created pull request #47 to fix this using David's commit as David's PR was done against his own fork.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants