Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust positioning and aspect ratio of blog post banners #4036

Open
melchoyce opened this issue Aug 2, 2024 · 2 comments
Open

Adjust positioning and aspect ratio of blog post banners #4036

melchoyce opened this issue Aug 2, 2024 · 2 comments
Assignees

Comments

@melchoyce
Copy link
Member

Feature suggestion

When designing the post layout for the new 18F site, I didn't take the banner guidelines into consideration. We should update the design of the posts to match the updated guidelines being worked on in https://github.com/18F/TLC-crew/issues/164.

Other considerations and design implementation suggestions

I've worked through some designs with @igorkorenfeld, @mitogi, and @cmajel and we've come up with this:

image
Figma link

Banner images should take up the full width of the grid, with their height scaling proportionally (instead of cropping an image). So an image using the banner guidelines would be around 1136x284, while a set of device screenshots, for example, could take up more height.

The tag positioning has been updated to better balance this new design.

@mitogi mitogi self-assigned this Aug 28, 2024
@mitogi mitogi removed their assignment Sep 16, 2024
@nateborr nateborr assigned nateborr and unassigned nateborr Sep 17, 2024
@nateborr nateborr self-assigned this Oct 15, 2024
@nateborr nateborr removed their assignment Oct 22, 2024
@neilmb neilmb self-assigned this Oct 22, 2024
@nateborr
Copy link
Member

@neilmb
Copy link
Member

neilmb commented Oct 23, 2024

The current markup in _includes/feature-image.html: is not ideal for this. There are other problems with the empty-figure-background-is-the-real-image markup in #3953 and #3977.

The current "Image in the background of a figure with a fixed height" gives a cool scrolling effect where it chops off the edges, but it isn't obvious how to get the right height in https://github.com/18F/18f.gsa.gov/blob/main/assets/common/styles/pages/blog.scss#L55 since that figure element with that class is actually completely empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants