From 0d9448bdcbc0aef26f008641602529f2cd8b9485 Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Fri, 8 Nov 2024 16:08:01 +0530 Subject: [PATCH 1/8] fix: getdebuginfo fails in skip preview flow --- packages/hms-video-store/src/IHMSActions.ts | 6 ++++-- packages/hms-video-store/src/sdk/index.ts | 6 +++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/hms-video-store/src/IHMSActions.ts b/packages/hms-video-store/src/IHMSActions.ts index 7eaea1424b..2251ab0c1b 100644 --- a/packages/hms-video-store/src/IHMSActions.ts +++ b/packages/hms-video-store/src/IHMSActions.ts @@ -582,6 +582,8 @@ export interface IHMSActions this.transport.isFlagEnabled(flag)); const initEndpoint = this.store.getConfig()?.initEndpoint; From c9f09ae5e186937de41020ada3050b4aae9338ca Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Fri, 8 Nov 2024 16:11:48 +0530 Subject: [PATCH 2/8] fix: copy spacing --- .../roomkit-react/src/Prebuilt/components/ErrorBoundary.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/roomkit-react/src/Prebuilt/components/ErrorBoundary.jsx b/packages/roomkit-react/src/Prebuilt/components/ErrorBoundary.jsx index a245758b59..215877a3a8 100644 --- a/packages/roomkit-react/src/Prebuilt/components/ErrorBoundary.jsx +++ b/packages/roomkit-react/src/Prebuilt/components/ErrorBoundary.jsx @@ -48,7 +48,8 @@ export class ErrorBoundary extends Component { Something went wrong Message: ${this.state.error}
- Please reload to see if it works. If you think this is a mistake on our side, please reach out to us on + Please reload to see if it works. If you think this is a mistake on our side, please reach out to us + on  Dashboard From 8327b889dc851d4287bee9444bd928dcf1bcfb48 Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Fri, 8 Nov 2024 17:01:03 +0530 Subject: [PATCH 3/8] fix: conditionally render stats for nerds modal --- packages/hms-video-store/src/sdk/index.ts | 2 +- .../components/MoreSettings/SplitComponents/MwebOptions.tsx | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/hms-video-store/src/sdk/index.ts b/packages/hms-video-store/src/sdk/index.ts index bb78be2186..164e728c82 100644 --- a/packages/hms-video-store/src/sdk/index.ts +++ b/packages/hms-video-store/src/sdk/index.ts @@ -283,7 +283,7 @@ export class HMSSdk implements HMSInterface { getDebugInfo(): DebugInfo | undefined { if (!this.transport) { - HMSLogger.e(this.TAG, `Transport is not defined`); + HMSLogger.w(this.TAG, `Transport is not defined`); return undefined; } const websocketURL = this.transport.getWebsocketEndpoint(); diff --git a/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx b/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx index 869d8f31d8..d2d347ec03 100644 --- a/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx +++ b/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx @@ -327,7 +327,9 @@ export const MwebOptions = ({ - + {openStatsForNerdsSheet && ( + + )} {openModals.has(MODALS.MUTE_ALL) && ( updateState(MODALS.MUTE_ALL, value)} isMobile /> From f3b3118150ab9ae9988dc3e6cd087b54d1330c36 Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Fri, 8 Nov 2024 17:28:44 +0530 Subject: [PATCH 4/8] fix: mark method as internal --- packages/hms-video-store/src/IHMSActions.ts | 3 ++- .../components/MoreSettings/SplitComponents/MwebOptions.tsx | 5 ++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/hms-video-store/src/IHMSActions.ts b/packages/hms-video-store/src/IHMSActions.ts index 2251ab0c1b..01cc905201 100644 --- a/packages/hms-video-store/src/IHMSActions.ts +++ b/packages/hms-video-store/src/IHMSActions.ts @@ -583,7 +583,8 @@ export interface IHMSActions - {openStatsForNerdsSheet && ( - - )} + + {openModals.has(MODALS.MUTE_ALL) && ( updateState(MODALS.MUTE_ALL, value)} isMobile /> From 65dbd2b9ef3bc986cbd211fd0597946871b8933b Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Fri, 8 Nov 2024 17:29:39 +0530 Subject: [PATCH 5/8] fix: convert warning to debug --- packages/hms-video-store/src/sdk/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/hms-video-store/src/sdk/index.ts b/packages/hms-video-store/src/sdk/index.ts index 164e728c82..c127db0d48 100644 --- a/packages/hms-video-store/src/sdk/index.ts +++ b/packages/hms-video-store/src/sdk/index.ts @@ -283,7 +283,7 @@ export class HMSSdk implements HMSInterface { getDebugInfo(): DebugInfo | undefined { if (!this.transport) { - HMSLogger.w(this.TAG, `Transport is not defined`); + HMSLogger.d(this.TAG, `Transport is not defined`); return undefined; } const websocketURL = this.transport.getWebsocketEndpoint(); From 9a158db9d3ce1be17846139141ec2dbce907ed2f Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Mon, 11 Nov 2024 11:57:14 +0530 Subject: [PATCH 6/8] fix: throw error if method is called before join --- packages/hms-video-store/src/sdk/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/hms-video-store/src/sdk/index.ts b/packages/hms-video-store/src/sdk/index.ts index c127db0d48..4925f43a68 100644 --- a/packages/hms-video-store/src/sdk/index.ts +++ b/packages/hms-video-store/src/sdk/index.ts @@ -284,7 +284,7 @@ export class HMSSdk implements HMSInterface { getDebugInfo(): DebugInfo | undefined { if (!this.transport) { HMSLogger.d(this.TAG, `Transport is not defined`); - return undefined; + throw new Error('getDebugInfo can only be called after join'); } const websocketURL = this.transport.getWebsocketEndpoint(); const enabledFlags = Object.values(InitFlags).filter(flag => this.transport.isFlagEnabled(flag)); From bad3cd8edaefc779f3ba4d35f00df41e41425aa1 Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Mon, 11 Nov 2024 12:00:37 +0530 Subject: [PATCH 7/8] fix: convert debug log to error log --- packages/hms-video-store/src/sdk/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/hms-video-store/src/sdk/index.ts b/packages/hms-video-store/src/sdk/index.ts index 4925f43a68..fe6040e751 100644 --- a/packages/hms-video-store/src/sdk/index.ts +++ b/packages/hms-video-store/src/sdk/index.ts @@ -283,7 +283,7 @@ export class HMSSdk implements HMSInterface { getDebugInfo(): DebugInfo | undefined { if (!this.transport) { - HMSLogger.d(this.TAG, `Transport is not defined`); + HMSLogger.e(this.TAG, `Transport is not defined`); throw new Error('getDebugInfo can only be called after join'); } const websocketURL = this.transport.getWebsocketEndpoint(); From 59d0339ced36672b8d31b15f84e1555b8bfd8872 Mon Sep 17 00:00:00 2001 From: KaustubhKumar05 Date: Mon, 11 Nov 2024 12:35:45 +0530 Subject: [PATCH 8/8] fix: render stats for nerds when opened --- .../components/MoreSettings/SplitComponents/MwebOptions.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx b/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx index ceb29f7238..ed1187f89c 100644 --- a/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx +++ b/packages/roomkit-react/src/Prebuilt/components/MoreSettings/SplitComponents/MwebOptions.tsx @@ -328,7 +328,7 @@ export const MwebOptions = ({ - + {openSettingsSheet && } {openModals.has(MODALS.MUTE_ALL) && ( updateState(MODALS.MUTE_ALL, value)} isMobile />