Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: how do we know when a new cryptocurrency is added to the SDN? #14

Open
mrose17 opened this issue May 7, 2024 · 5 comments
Open

Q: how do we know when a new cryptocurrency is added to the SDN? #14

mrose17 opened this issue May 7, 2024 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mrose17
Copy link

mrose17 commented May 7, 2024

My guess from reading https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/main/generate-address-list.py#L12 is that someone periodically fetches the XML file, does a grep and then compares that to the list at https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/main/generate-address-list.py#L13-L15

I am wondering if a better implementation strategy might be to have the script do two passes: first, to look for <FeatureType/> starting with "Digital Currency Address - ", to build up the list on lines 13-15, and, second, to proceed as usual. of course, i'd still keep what's on lines 13-15, just as a safety.

Your thoughts?

@0xB10C
Copy link
Owner

0xB10C commented May 8, 2024

I'm not actively monitoring for new coins being added to the SDN list - for me personally, only XBT is relevant. However, I accept PRs (#7, #6) to add new coins and will review and merge them.

As the CI is already running each night to check if there are new entries for the existing coins, there could also be a job that runs after uploading potential new entries - failing or otherwise alerting that there are new coins. Happy to create an issue for each new coin when the CI fails. Someone (not necessarily me, but I might do it if I have the time) can then create a PR to add the new coin.

@mrose17
Copy link
Author

mrose17 commented May 20, 2024

Thank you!

@mrose17 mrose17 closed this as completed May 20, 2024
@0xB10C
Copy link
Owner

0xB10C commented May 20, 2024

We might want to keep this open and not "closed as completed". The new CI task I was talking about doesn't exist yet. Someone might want to add that.

Reopening with the help wanted label.

@0xB10C 0xB10C reopened this May 20, 2024
@0xB10C 0xB10C added help wanted Extra attention is needed good first issue Good for newcomers labels May 20, 2024
@nickmura
Copy link

nickmura commented Oct 26, 2024

hey i was wondering if this is a related issue, let alone coins, but new addresses, on branch lists, does the github actions event still work where it updates addresses? does it update on an interval? looking at the commit history it doesn't seem to be a interval of changes. on what day of each month can we expect to see new addresses

@0xB10C
Copy link
Owner

0xB10C commented Oct 29, 2024

The list branch is only updated when the underlying OFAC list changes - this happens infrequently. The OFAC list is downloaded an processed daily. See https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions and

@0xB10C 0xB10C mentioned this issue Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants