Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] Make the sentence more inclusive in time for its-a-match #2766

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

sadiqui
Copy link
Contributor

@sadiqui sadiqui commented Oct 9, 2024

Using "ever" broadens the scope of the question, making it more inclusive of all past experiences, while the previous phrasing implies only a more recent or continuous reflection, focusing on a continuous action just before now. The modification emphasizes the idea of whether a person have ever thought about it at all.

@HarryVasanth HarryVasanth changed the title Make the sentence more inclusive in time [External] Make the sentence more inclusive in time Oct 18, 2024
@HarryVasanth HarryVasanth changed the title [External] Make the sentence more inclusive in time [EXTERNAL] Make the sentence more inclusive in time Oct 18, 2024
Copy link
Member

@HarryVasanth HarryVasanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The construction "ever been pondering" is not typically used and sounds awkward. The continuous form with "been pondering" doesn't pair well with "ever" in this context. "Ever" is usually used with the present perfect simple tense "have pondered" rather than the present perfect continuous "have been pondering".

@HarryVasanth HarryVasanth changed the title [EXTERNAL] Make the sentence more inclusive in time [EXTERNAL] Make the sentence more inclusive in time for its-a-match Oct 18, 2024
@sadiqui
Copy link
Contributor Author

sadiqui commented Oct 22, 2024

Using "ever" broadens the scope of the question, making it more inclusive of all past experiences, while the previous phrasing implies only a more recent or continuous reflection, focusing on a continuous action just before now. The modification emphasizes the idea of whether a person have ever thought about it at all.

To keep the inclusivity of time while maintaining natural phrasing, it could be better as "Have you ever pondered the etymology of grep?"

@sadiqui sadiqui requested a review from HarryVasanth October 22, 2024 17:59
Copy link
Member

@HarryVasanth HarryVasanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the inclusivity of time while maintaining natural phrasing, it could be better as "Have you ever pondered the etymology of grep?"

Yes it works!

@sadiqui sadiqui requested a review from HarryVasanth October 30, 2024 12:39
@HarryVasanth HarryVasanth merged commit 29bfad2 into 01-edu:master Oct 30, 2024
3 checks passed
@sadiqui sadiqui deleted the patch-1 branch October 30, 2024 21:40
@HarryVasanth HarryVasanth added the 🗂️ docs Documentation label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗂️ docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants