-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXTERNAL] Make the sentence more inclusive in time for its-a-match
#2766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The construction "ever been pondering" is not typically used and sounds awkward. The continuous form with "been pondering" doesn't pair well with "ever" in this context. "Ever" is usually used with the present perfect simple tense "have pondered" rather than the present perfect continuous "have been pondering".
its-a-match
To keep the inclusivity of time while maintaining natural phrasing, it could be better as "Have you ever pondered the etymology of grep?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep the inclusivity of time while maintaining natural phrasing, it could be better as "Have you ever pondered the etymology of grep?"
Yes it works!
Using "ever" broadens the scope of the question, making it more inclusive of all past experiences, while the previous phrasing implies only a more recent or continuous reflection, focusing on a continuous action just before now. The modification emphasizes the idea of whether a person have ever thought about it at all.