Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] Fixing a few minor things in subjects from the RUST piscine #2663

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

TheOldestBrother
Copy link
Contributor

Why?

A few student and myself found a few things that could be improved in different subjects README files, I did my best to attend to these changes.

1 - Adding a reminder of what a prime number is, a few student didn't remembered in an exam and were stuck because of that.

2 - Specifying the input type awaited by the test program to avoid a simple mistake and some frustration.

3 - Modifying the example for the nb_games : a few people struggle with this as they didn't understand that this input would determine a few other variables. I thought that with 2 examples the point would be made clearer.

@pedrodesu pedrodesu self-assigned this Nov 20, 2024
@pedrodesu pedrodesu added the 📕 Rust Rust label Nov 20, 2024
@pedrodesu
Copy link
Contributor

Hello @TheOldestBrother!

First and foremost, do excuse us for the delay, I was just now assigned this case. We appreciate your suggestion!
I took a look at your proposition. It seems interesting, especially given that it takes into account direct feedback from students from schools.
I made some minor changes for matters of uniformity and so it's according to the master branch as is and our Prettier workflow. They'll be pushed as soon as possible. Please let me know what you think of them and do comment further on it if you have some additional feedback.

Thank you very much.

@pedrodesu pedrodesu closed this Nov 20, 2024
@pedrodesu pedrodesu reopened this Nov 20, 2024
@pedrodesu pedrodesu requested a review from MSilva95 November 20, 2024 11:43
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pedrodesu pedrodesu merged commit 422aff5 into 01-edu:master Nov 20, 2024
4 checks passed
@TheOldestBrother
Copy link
Contributor Author

Hi @pedrodesu!

I'm sorry as well for the late reply, I had lost hope that the request would be merged but I'm happily surprised to see that it has been implemented ! (it is actually my first pull request so I hope it was okay).

I thank you all for the time you took with my suggestions and I would love to make more in the future, I think that I can still get more feedback from my fellow students that could help improve some of the projects or at least get rid of some misunderstandings that we came across.

As I'm still learning how to cooperate in this platform, I would love if you could recommend any materials that could improve my future request or maybe a guide on the specifics about cooperating in this repository. I would very much like to avoid making your work harder by making difficult requests.

Thank you very much for allowing me to be part of this change!

@pedrodesu
Copy link
Contributor

Hello @TheOldestBrother!

Your PR was written in very good means, you've nothing to worry in that regard!

About future suggestions, we of course welcome any feedback you or any peer of yours might want to share. We're continuously striving to improve our content so all suggestions are welcome, especially if it comes directly from our zones.
You should also know the content team is giving careful attention to the Rust piscine at the moment, so changes inside of it are to be expected briefly. Some of these changes do already take into account direct feedback from the zones' students, but nevertheless, please feel free to let us know where we can improve!

Regarding your last request, as I mentioned previously, you don't really have much to worry about, your PR was well formed and I didn't need to do too much extra work on it. What I can tell you regarding this repository is to kindly follow the convention that appears when you go for creating a PR, as it seems you properly did on this one.

We appreciate your time and your help a lot!

@TheOldestBrother
Copy link
Contributor Author

Hello @pedrodesu,

I'm happy that I could be of some help and will come back in the future with more feedback! I thank you for your time, this has been very interesting learning point for me.

A good day to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants