Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] Update calculator_test.sh #2538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r0cketdyne
Copy link

Added set -euo pipefail to enforce safer scripting practices.

Improved variable scoping within the challenge function.

Simplified the function calls within the challenge function.

Refactored the test for the use of case statement.

Updated the invalid input tests to include better error handling.

Reorganized and improved the testing of operator functions.

Added a final message indicating the success of all tests.

Before starting, please choose the relevant pull request Labels, Reviewers, and Assignees

DEV-#### | SUP-#### | CON-####

Why?

Clearly state the reason for this change. What problem is it solving, or what feature is it adding?

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high-level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub-compliant mermaid graphs to represent the solution visually.

Implementation Details

Explain the details of the implementation and the reasoning behind it. What alternative approaches were considered, and why was this approach chosen?

Build Images

Please assign the label 📦 build If you want to re-build the following test images:

  • 💻 Sh
  • 🚀 JS
  • 🧩 DOM

Added set -euo pipefail to enforce safer scripting practices.

Improved variable scoping within the challenge function.

Simplified the function calls within the challenge function.

Refactored the test for the use of case statement.

Updated the invalid input tests to include better error handling.

Reorganized and improved the testing of operator functions.

Added a final message indicating the success of all tests.
@HarryVasanth HarryVasanth changed the title Update calculator_test.sh [EXTERNAL] Update calculator_test.sh Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants