Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXTERNAL] undefine eval() for elementary.js #2490

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ExTBH
Copy link

@ExTBH ExTBH commented Mar 11, 2024

Before starting, please choose the relevant pull request Labels, Reviewers, and Assignees

DEV-#### | SUP-#### | CON-####

Why?

Clearly state the reason for this change. What problem is it solving, or what feature is it adding?

The question can be skipped using eval

function multiply(n1, n2) {
    return eval(`${n1} ${String.fromCharCode(42)} ${n2}`)
}
function divide(n1, n2) {
    return eval(`Math.trunc(${n1} ${String.fromCharCode(47)} ${n2})`)
}
function modulo(n1, n2) {
    return eval(`Math.trunc(${n1} ${String.fromCharCode(37)} ${n2})`)
}

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high-level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub-compliant mermaid graphs to represent the solution visually.

Implementation Details

Explain the details of the implementation and the reasoning behind it. What alternative approaches were considered, and why was this approach chosen?

Build Images

Please assign the label 📦 build If you want to re-build the following test images:

  • 💻 Sh
  • 🚀 JS
  • 🧩 DOM

@HarryVasanth HarryVasanth changed the title undefine eval() for elementary.js [EXTERNAL] undefine eval() for elementary.js Jul 8, 2024
@HarryVasanth HarryVasanth added the 📕 JS JavaScript label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕 JS JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants