Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rust piscine): Add binary_search optional exercise subject #2222

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

akhossanX
Copy link
Contributor

No description provided.

@akhossanX akhossanX requested a review from mikysett September 25, 2023 22:27
@akhossanX akhossanX self-assigned this Sep 25, 2023
Copy link
Contributor

@mikysett mikysett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subject is great, it is just missing a convention and maybe there is a list placed in the wrong spot.

subjects/binary_search/README.md Show resolved Hide resolved
subjects/binary_search/README.md Outdated Show resolved Hide resolved
@akhossanX akhossanX requested a review from mikysett September 28, 2023 22:01
Copy link
Contributor

@mikysett mikysett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akhossanX akhossanX merged commit 3a09fc1 into master Oct 4, 2023
2 checks passed
@akhossanX akhossanX deleted the CON-2184-binary_search-optional-exercise-subject branch October 4, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants