Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time-series subject Exercise 2 suprise audit questions #2298

Closed
jarmo-seljamaa opened this issue Nov 23, 2023 · 1 comment · Fixed by #2303
Closed

time-series subject Exercise 2 suprise audit questions #2298

jarmo-seljamaa opened this issue Nov 23, 2023 · 1 comment · Fixed by #2303
Assignees

Comments

@jarmo-seljamaa
Copy link

time-series

The task description of Exercise 2 is pretty straightforward: 1) plot a candlestick, 2) aggregate data and 3) compute daily return.

The audit of that same exercise contains a list of operations that must be done on the data prior to these tasks described above. I do understand that this should be a standard practice when working with a data, but this is not something everyone knows from birth. At least in the first exercise of that kind it would be nice to give a hint to check the data types, missing values, indexes etc before proceeding to the actual task, no?

@MSilva95 MSilva95 self-assigned this Nov 24, 2023
@MSilva95
Copy link
Member

Hello @jarmo-seljamaa i will add more info in the readme, thank you for the feedback!

@MSilva95 MSilva95 linked a pull request Nov 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants